Skip to content

Conversation

LamentXU123
Copy link
Contributor

@LamentXU123 LamentXU123 commented Jul 13, 2025

There are two warnings:

C:\Users\admin\Downloads\cpython-main\Doc\library\xml.sax.handler.rst:249: WARNING: py:class reference target not found: xml.sax.xmlreader.Attributes [ref.class]
C:\Users\admin\Downloads\cpython-main\Doc\library\xml.sax.handler.rst:271: WARNING: py:class reference target not found: xml.sax.xmlreader.AttributesNS [ref.class]

This warning happens in many doc of xml (xml.sax.reader, xml.sax.handler, xml.sax) in the same reason. After staring the doc for a while, I think the original doc want to refer to xml.sax.xmlreader.AttributesImpl and xml.sax.xmlreader.AttributesNSImpl as an implemention of attributes-interface. This doc fix it to the correct ref.

If this is approved, I will fix up those occurrence in other docs, an example of this in xml.sax is as below to double check.

image

📚 Documentation preview 📚: https://cpython-previews--136612.org.readthedocs.build/

@LamentXU123 LamentXU123 changed the title gh-101100: Fix sphinx warnings in library/xml.sax.rst gh-101100: Fix sphinx warnings in library/xml.sax.handler.rst Jul 14, 2025
@LamentXU123 LamentXU123 marked this pull request as draft July 14, 2025 15:21
@LamentXU123
Copy link
Contributor Author

Fixed to:
image

@LamentXU123 LamentXU123 marked this pull request as ready for review July 14, 2025 15:27
@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Sep 3, 2025
@AA-Turner AA-Turner changed the title gh-101100: Fix sphinx warnings in library/xml.sax.handler.rst gh-101100: Resolve reference warnings in library/xml.sax.handler.rst Sep 3, 2025
@AA-Turner AA-Turner merged commit c22cc8f into python:main Sep 3, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @LamentXU123 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Sep 3, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 3, 2025

GH-138421 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 3, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 3, 2025

GH-138422 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 3, 2025
AA-Turner pushed a commit that referenced this pull request Sep 3, 2025
hugovk pushed a commit that referenced this pull request Sep 3, 2025
…er.rst (GH-136612) (#138421)

gh-101100: Resolve reference warnings in library/xml.sax.handler.rst (GH-136612)
(cherry picked from commit c22cc8f)

Co-authored-by: Weilin Du <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
….handler.rst (pythonGH-136612) (python#138421)

pythongh-101100: Resolve reference warnings in library/xml.sax.handler.rst (pythonGH-136612)
(cherry picked from commit c22cc8f)

Co-authored-by: Weilin Du <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants